Update test templates to Linux community gallery images #5960
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
cncf-cla: yes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5960 +/- ##
=======================================
Coverage 44.54% 44.54%
=======================================
Files 279 279
Lines 25140 25140
=======================================
Hits 11199 11199
Misses 13128 13128
Partials 813 813 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/cherry-pick release-1.21 |
|
@mboersma: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| publisher: cncf-upstream | ||
| offer: capi | ||
| sku: ubuntu-2204-gen1 | ||
| computeGallery: |
There was a problem hiding this comment.
Adding to the "someday" list: refactor this kustomize so we only need to make this change in one place instead of 15.
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: ee447d79149ad0a9eae11334f844940fdb5fa59a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold for tests since I'm not sure the required jobs use these templates. |
k8s-ci-robot
added
the
do-not-merge/hold
| sku: ubuntu-2204-gen1 | ||
| computeGallery: | ||
| gallery: ClusterAPI-f72ceb4f-5159-4c26-a0fe-2ea738f0d019 | ||
| name: capi-ubun2-2404 |
There was a problem hiding this comment.
For the Windows images named ${WINDOWS_SERVER_VERSION:=windows-2019}-containerd-gen1 in the Marketplace and like capi-win-2019-containerd in the compute gallery, neither I nor Copilot found a way to do both "default the variable if not set" and "replace this pattern with this" in a single envsubst expression. Maybe it would work to default the variable in ci-entrypoint, ci-conformance, and ci-e2e then only do the pattern replacement here in the template?
There was a problem hiding this comment.
Yes, I tried the same. I think it's either that or change WINDOWS_SERVER_VERSION in a backward-incompatible way, so it's just "2022" instead of "windows-2022". This would be simplest but requires downstream consumers of the templates potentially to change a var in testgrid jobs.
|
/retitle Update test templates to Linux community gallery images |
k8s-ci-robot
changed the title
|
tests are green! |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@mboersma: new pull request created: #5961 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Conformance jobs running against CAPZ's 1.20 branch with k/k@master are failing and this PR should fix that: https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-azure#capz-periodic-conformance-k8s-ci-v1beta1-release-1-20. It should also fix the SIG-Scalability job while kubernetes/test-infra#35632 gets reviewed: https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-azure#azure-master-scalability-100. /cherry-pick release-1.20 |
|
@nojnhuh: #5960 failed to apply on top of branch "release-1.20": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates templates to use reference images from the CAPZ Community Gallery.
Some CI templates were still referencing Azure Marketplace images, which are deprecated and will no longer work for testing Kubernetes v1.35+.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
TODOs:
Release note: